app/assets/javascripts/discourse/routes/topic-unsubscribe.js.es6 (3)

4-9: No error handling for loadTopicView — user sees a generic error on failure.

If the topic doesn't exist or the network request fails, the rejected promise propagates to the default Ember route error handler. For an unsubscribe page (often reached from email links), showing a friendly error message is important.

💡 Suggested improvement

   model(params) {
     const topic = this.store.createRecord("topic", { id: params.id });
     return PostStream.loadTopicView(params.id).then(json => {
       topic.updateFromJson(json);
       return topic;
+    }).catch(() => {
+      return Ember.RSVP.reject({ not_found: true });
     });
   },

Alternatively, implement an error action in the route to render a user-friendly message for unsubscribe failures.

---

12-15: afterModel assumes topic.details is populated — add a guard.

If updateFromJson fails to populate details (e.g., unexpected JSON shape), this will throw. A simple guard avoids a runtime error on the unsubscribe page.

🛡️ Defensive check

   afterModel(topic) {
     // hide the notification reason text
-    topic.set("details.notificationReasonText", null);
+    if (topic.get("details")) {
+      topic.set("details.notificationReasonText", null);
+    }
   },

---

1-3: Discourse.Route is used as a global while PostStream is explicitly imported.

For consistency with the import PostStream on Line 1, consider importing the Route base class as well instead of relying on the Discourse global. This is a minor consistency nit in the context of a legacy codebase.

app/assets/javascripts/discourse/routes/topic-from-params.js.es6 (1)

11-16: Partial ES6 modernization: self = this pattern can be eliminated with arrow functions.

The var → const upgrade is good, but const self = this (Line 11) is still needed only because Line 23 uses function(). Converting to an arrow function would complete the modernization and remove the self alias.

♻️ Suggested change

-    const self = this,
-          topic = this.modelFor('topic'),
+    const topic = this.modelFor('topic'),
           postStream = topic.get('postStream'),
           topicController = this.controllerFor('topic'),
           topicProgressController = this.controllerFor('topic-progress'),
           composerController = this.controllerFor('composer');
     ...
-    postStream.refresh(params).then(function () {
+    postStream.refresh(params).then(() => {
       ...
       Ember.run.scheduleOnce('afterRender', function() {
-        self.appEvents.trigger('post:highlight', closest);
+        this.appEvents.trigger('post:highlight', closest);
       });

Also applies to: 23-23

app/assets/javascripts/discourse/controllers/topic-unsubscribe.js.es6 (1)

1-3: Minor version correction needed in deprecation timeline: ObjectController was deprecated in Ember 1.11 (not 1.13) and removed in Ember 2.0.

Note that this codebase uses a custom ObjectController wrapper defined in app/assets/javascripts/discourse/controllers/object.js.es6 which extends Ember.ObjectController. If modernizing, replace with Ember.Controller and explicitly reference model properties rather than relying on proxying behavior. This pattern is used extensively across 40+ controllers in the codebase, so refactoring should be systematic if undertaken.